Use a long password on generated in-memory KeyStore#4907
Merged
vietj merged 2 commits intoeclipse-vertx:masterfrom Oct 16, 2023
Merged
Use a long password on generated in-memory KeyStore#4907vietj merged 2 commits intoeclipse-vertx:masterfrom
vietj merged 2 commits intoeclipse-vertx:masterfrom
Conversation
Member
|
thanks, tests are failing with |
Contributor
Author
Hi. I fixed the KeyStoreHelper tests in my latest commit. Locally I have a couple of other failures on timeouts that look unrelated with this change. Hopefully it runs better in the Github Actions build. |
Contributor
Author
|
Hi @vietj Thank you for considering this fix for the 5.0 milestone. Is there a chance to get this fix in a 4.4 release also ? Should I propose a PR for a 4.4 branch ? |
Member
|
can you provide a PR for 4.x branch ? |
Contributor
Author
Here it is : #4910 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Fix for #4906
Hopefully trivial enough to have no wrong side-effect.